Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpers to default export type declaration as in sources #1408

Merged
merged 2 commits into from Sep 27, 2018
Merged

Add helpers to default export type declaration as in sources #1408

merged 2 commits into from Sep 27, 2018

Conversation

nulpatrol
Copy link
Contributor

Partially based on #1274
Import Vuex.

import Vuex from "vuex";

Using before this PR:

(Vuex as any).mapActions(...)

Using after:

Vuex.mapActions(...)

ktsn
ktsn requested changes Sep 27, 2018
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add createNamespacedHelpers?
https://github.com/vuejs/vuex/blob/dev/src/index.esm.js#L12

ktsn
ktsn approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ktsn ktsn merged commit 404d0de into vuejs:dev Sep 27, 2018
@ktsn ktsn mentioned this pull request Sep 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nulpatrol @ktsn