Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-hans] use zh-hans instead of zh-cn #904

Closed
wants to merge 1 commit into from
Closed

[zh-hans] use zh-hans instead of zh-cn #904

wants to merge 1 commit into from

Conversation

lanceli
Copy link
Contributor

@lanceli lanceli commented Aug 12, 2017

Currently the docs of simplified Chinese shown traditional Chinese by gitbook.
Use zh-hans instead of zh-cn to fix it.

Refs:

https://github.com/GitbookIO/gitbook/blob/b48f8472d35b27d549d7c9a5b61f77f6b78e1908/CHANGES.md#260

WechatIMG17.jpeg

@lanceli lanceli changed the title [zh-hans] use zh-hans instead of zh-cn, ref:https://github.com/GitbookIO/gitbook/commit/5d1c4d2b9fabedaddaf271f1a5da19aacaaee6c9 [zh-hans] use zh-hans instead of zh-cn Aug 12, 2017
@Jinjiang
Copy link
Member

This will lead the existing zh-cn links broken. I suggest to keep the current links available first and think another way instead.
Thanks

@lanceli
Copy link
Contributor Author

lanceli commented Aug 14, 2017

For me it's better to change all existing zh-cn links to zh-hans in the long term, and there is same issue with others docs, e.g. vue-loader

@ktsn ktsn added the documentation Improvements or additions to documentation label Aug 27, 2017
@Jinjiang
Copy link
Member

I found that the default theme of GItbook don't have _i18n/zh-cn.json. So it automatically matches to _i18n/zh-tw.json.

My suggestion is create a PR to gitbook theme-default to add a zh-cn.json file. There are two main reasons: 1. Actually all current content translation is simplified Chinese (except the GitBook theme itself); 2. The zh-cn urls has been published.

Thanks.

@lanceli
Copy link
Contributor Author

lanceli commented Sep 18, 2017

Up to you, and i do not think they will accept your suggestion base on this: GitbookIO/gitbook#926
and GitbookIO/gitbook@5d1c4d2

@lanceli lanceli closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants