fix(core): ensure page.title is string, close #1306 #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mister-Hope
changed the title
meteorlxy
reviewed
Apr 24, 2023
| @@ -74,6 +74,6 @@ export const renderPageContent = ({ | |||
| 'frontmatter' | |||
| ), | |||
| sfcBlocks, | |||
| title: frontmatter.title ?? title, | |||
| title: isString(frontmatter.title) ? frontmatter.title : title, | |||
There was a problem hiding this comment.
Maybe
frontmatter.title ? `${frontmatter.title}` : title
Users should expect to use the frontmatter title if they set it, so it could be better to make something different even if the value is wrong.
There was a problem hiding this comment.
Emm, then why not String(frontmatter.title)
There was a problem hiding this comment.
As I remember, string template has better performance than string constructor in most cases.
The only difference is that string constructor can handle symbol, while string template cannot. But I think frontmatter.title is impossible to be a symbol value in this case.
Mister-Hope
commented
May 11, 2023
|
This should be ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.