Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init guidelines #198

Merged
merged 69 commits into from
Aug 22, 2024
Merged

feat: init guidelines #198

merged 69 commits into from
Aug 22, 2024

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Jun 5, 2024

No description provided.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9383527805

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.168%

Totals Coverage Status
Change from base Build 9381003398: 0.0%
Covered Lines: 992
Relevant Lines: 1582

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9383802306

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.168%

Totals Coverage Status
Change from base Build 9381003398: 0.0%
Covered Lines: 992
Relevant Lines: 1582

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9384752644

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.168%

Totals Coverage Status
Change from base Build 9381003398: 0.0%
Covered Lines: 992
Relevant Lines: 1582

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9396850614

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.168%

Totals Coverage Status
Change from base Build 9381003398: 0.0%
Covered Lines: 992
Relevant Lines: 1582

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 19, 2024

Pull Request Test Coverage Report for Build 10502556700

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.488%

Totals Coverage Status
Change from base Build 10474691820: 0.0%
Covered Lines: 1091
Relevant Lines: 1706

💛 - Coveralls

@Mister-Hope Mister-Hope changed the base branch from main to highlighter-style July 19, 2024 05:03
Base automatically changed from highlighter-style to main July 19, 2024 08:17
@Mister-Hope
Copy link
Member Author

Mister-Hope commented Aug 20, 2024

This PR is now ready for review.

Basically, this PR introduce theme guideline:

  • A theme must declare attributes on certain component for plugins to "select them" correctly by default
  • A theme must declare its color scheme with the given way, so that plugins can get darkmode status easily
  • A theme must provide a set of colors and transition variables, so that plugins can use them and fit the theme palette by default.

Note: Since we already decide to introduce a new theme and rename the current one as classic (not sure about the progress @pengzhanbo), so I decide not to migrate the custom container and badge colors, as they are with the classic theme totally.

@Mister-Hope Mister-Hope merged commit e8258c1 into main Aug 22, 2024
28 checks passed
@Mister-Hope Mister-Hope deleted the guidelines branch August 22, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants