Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin-revealjs #251

Merged
merged 22 commits into from
Sep 22, 2024
Merged

feat: add plugin-revealjs #251

merged 22 commits into from
Sep 22, 2024

Conversation

Mister-Hope
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 22, 2024

Pull Request Test Coverage Report for Build 10980872768

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 58.636%

Totals Coverage Status
Change from base Build 10979829312: 0.3%
Covered Lines: 1168
Relevant Lines: 1794

💛 - Coveralls

@Mister-Hope Mister-Hope marked this pull request as ready for review September 22, 2024 02:50
@Mister-Hope
Copy link
Member Author

@pengzhanbo

This PR is almost ready with the following things that need to be specially reviewed:

  1. To make the layout treeshakable, I define a alias and constanst in plugin, and I am wondering if we can make it more graceful.
  2. The mouse scroll view is not working at the demo page, while the original demo from md-enhance (see https://plugin-md-enhance.vuejs.press/guide/content/revealjs/demo.html) is working fine. I already took time to investigate this, but failed to find out the problem.

@pengzhanbo
Copy link
Member

  • To make the layout treeshakable, I define a alias and constanst in plugin, and I am wondering if we can make it more graceful.

The current implementation seems fine, and further optimization would just be similar to the approach used in other plugins, like (app) => prepareClientConfig(app).

@Mister-Hope
Copy link
Member Author

Any ideas with the second one?

@Mister-Hope Mister-Hope merged commit 253b959 into main Sep 22, 2024
28 checks passed
@Mister-Hope Mister-Hope deleted the plugin-reveal-js branch September 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants