Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TODO syntax colors #5

Closed
brokenthorn opened this issue Aug 6, 2019 · 9 comments
Closed

Improve TODO syntax colors #5

brokenthorn opened this issue Aug 6, 2019 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@brokenthorn
Copy link
Contributor

JetBrains IDEs have built in "// TODO" and "// FIXME" highlighting as well as customisable "TODO keywords":

image

The defaults are just two keywords: TODO and FIXME. They both are set to use the color scheme default TODO colors:

image

The issue I'm reporting is that vuesion's default TODO colors are not visible enough:

image

The desired look for me is something resembling this:

image

If there are any "Vue" colors that are a bit more vibrant, normal weighted text could work too.
Above is bold.

Or some variation on the current colors (TODO set brightness 100%, FIXME set brightness 100%, HUE to 0):

image

@devCrossNet
Copy link
Member

@brokenthorn
Copy link
Contributor Author

brokenthorn commented Aug 28, 2019

In that case, how does this look:

image

"WARN" is not a default TODO keyword. I added that myself, but if the color scheme can specify these default colors, I guess the TODO color can be replace with the WARN color used in the example (because it's a bit brigther).

As I understand, color schemes can specify default TODO colors, so can you set these defaults?

@devCrossNet
Copy link
Member

looks great 👍

I don't have much time at the moment - I'll work on it asap, or you can create a PR

@brokenthorn
Copy link
Contributor Author

Any idea how to get a current build of the plugin and install it with IntelliJ, for testing purposes? Something simple, if possible.

@devCrossNet
Copy link
Member

hey @brokenthorn,
the easiest way I found so far is to create a new IntelliJ project and copy the contents of this repository into it. Here is the tutorial on how to do it: http://www.jetbrains.org/intellij/sdk/docs/reference_guide/ui_themes/themes.html

From then on if you open the theme file vuesion_theme.theme.json, you have a run button on the upper left which applies the whole theme to the IntelliJ IDE.

I didn't find a way so far to just check out this project and run it

@brokenthorn
Copy link
Contributor Author

I was really hoping you'd come back saying you had a way you could release beta builds that can be downloaded from here. ^_^

@devCrossNet devCrossNet added the bug Something isn't working label Oct 2, 2019
@devCrossNet
Copy link
Member

update it uploaded and I am waiting for approval: https://plugins.jetbrains.com/plugin/12226-vuesion-theme/update/69760

I think we can close this now? @brokenthorn

@brokenthorn
Copy link
Contributor Author

Link goes to 404 page.

@devCrossNet
Copy link
Member

not for me 🤔

anyway, the new version is published: https://plugins.jetbrains.com/plugin/12226-vuesion-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants