Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

port 431 from vsf-api #59

Merged
merged 1 commit into from
Apr 11, 2020
Merged

port 431 from vsf-api #59

merged 1 commit into from
Apr 11, 2020

Conversation

gibkigonzo
Copy link
Contributor

Short description and why it's useful

port 431 vuestorefront/vue-storefront-api#431 vsf-api
I made new file for this function, please guide me if there is a better place for this.

IMPORTANT NOTICE - Remember to update CHANGELOG.md with a description of your change

Contribution and currently important rules acceptance

@pkarw pkarw requested a review from ResuBaka April 10, 2020 12:33
Copy link
Collaborator

@ResuBaka ResuBaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good I only have one question.
Why are here changes in the yarn.lock?

@gibkigonzo
Copy link
Contributor Author

gibkigonzo commented Apr 10, 2020

sorry, I can make new pr with updated yarn.lock. This appear because there were updates in package.json,for example pm2 https://github.com/DivanteLtd/storefront-api/blob/develop/package.json#L103, but yarn.lock still has old version https://github.com/DivanteLtd/storefront-api/blob/develop/yarn.lock#L10441

Copy link
Collaborator

@ResuBaka ResuBaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine maybe it was intended because of something, so I just wanted to ask before approving.

@pkarw pkarw merged commit 7c4ea86 into vuestorefront:develop Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants