feat: childrenTag prop for SfListItem #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ebc0e57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
[storefront-ui-vue] Please retry analysis of this Pull-Request directly on SonarCloud. |
justyna-13
requested review from
Szymon-dziewonski,
FRSgit,
dkacper and
mattmaribojoc
as code owners
dkacper
reviewed
Jul 4, 2023
FRSgit
reviewed
Jul 7, 2023
Szymon-dziewonski
approved these changes
Jul 7, 2023
FRSgit
reviewed
Jul 7, 2023
Comment on lines
+130
to
+131
| before(() => (childrenTag = 'div')); | ||
| after(() => (childrenTag = 'span')); |
FRSgit
approved these changes
Jul 7, 2023
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! |
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed! |
Szymon-dziewonski
pushed a commit
that referenced
this pull request
Oct 2, 2023
* feat:childrenTag prop for SfListItem * fix: cr fixes * fix: lint fixes * fix: cr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes # https://vsf.atlassian.net/browse/SFUI2-1082
Scope of work
childrenTag prop for SfListItem
Screenshots of visual changes
Checklist