fix(SfSelect): correct usage of v-model [SFUI2-1300] #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szymon-dziewonski
requested review from
FRSgit,
dkacper and
mattmaribojoc
as code owners
🦋 Changeset detectedLatest commit: c9728e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Szymon-dziewonski
force-pushed
the
fix--sfselect-v-model
branch
3 times, most recently
from
90e481a
to
9c937a7
Compare
FRSgit
reviewed
Jul 25, 2023
FRSgit
reviewed
Jul 25, 2023
FRSgit
reviewed
Jul 25, 2023
Szymon-dziewonski
force-pushed
the
fix--sfselect-v-model
branch
from
9c937a7
to
6091d4f
Compare
|
[storefront-ui-vue] Kudos, SonarCloud Quality Gate passed! |
|
[storefront-ui-react] Kudos, SonarCloud Quality Gate passed!
|
FRSgit
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
https://vsf.atlassian.net/browse/SFUI2-1300
Scope of work
SfSelect pass wrongly
modelValue, asvalueprop and thenemitsstate via@onChangewhich did not work3e3ba8d0-4b59-47e1-8d5f-1ef1df271afb.webm
Wrong applying
valueinsortingblock, it was served as Object when it should be StringAdditionally some block used
asinstead oftagpropScreenshots of visual changes
Checklist