Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: implement usePayment composable #67

Closed
1 task done
Baroshem opened this issue Aug 31, 2021 · 0 comments · Fixed by #103
Closed
1 task done

[Feature]: implement usePayment composable #67

Baroshem opened this issue Aug 31, 2021 · 0 comments · Fixed by #103
Labels
enhancement New feature or request
Milestone

Comments

@Baroshem
Copy link
Contributor

How the project can be improved?

Currently in some cases we are calling the api-client directly and that should be done by a composable rather than from the theme, i.e.:

    const response = await $vendure.api.setPaymentMethod({
      method: paymentMethod?.value?.code,
      metadata: {
        // Here you would pass data from an external Payment Provided after successful payment process like payment id.
      }
    });

We should develop a new composable and factory called usePayment call the api-client methods from there.

What are the acceptance criteria?

  • [ ]

Additional information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Baroshem Baroshem added the enhancement New feature or request label Aug 31, 2021
@Baroshem Baroshem added this to the 1.0.0-beta.2 milestone Sep 2, 2021
@Baroshem Baroshem modified the milestones: 1.0.0-beta.2, 1.0.0-beta.3 Sep 20, 2021
Baroshem added a commit that referenced this issue Sep 25, 2021
@Baroshem Baroshem mentioned this issue Sep 25, 2021
9 tasks
Baroshem added a commit that referenced this issue Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant