Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the data fetching logic out from themes #11

Closed
pkarw opened this issue Sep 26, 2017 · 0 comments
Closed

Move the data fetching logic out from themes #11

pkarw opened this issue Sep 26, 2017 · 0 comments
Milestone

Comments

@pkarw
Copy link
Collaborator

pkarw commented Sep 26, 2017

It should be placed within /components or /pages:

  • /vue-storefront/src/themes/default/components/core/blocks/SidebarMenu/SidebarMenu.vue
@karolbzik karolbzik assigned filrak and unassigned pkarw Oct 30, 2017
@pkarw pkarw modified the milestones: 0.2.0 PoC with the checkout and RWD, 0.4.0 PoC with customer's dashboard and favorite widget Nov 30, 2017
@pkarw pkarw modified the milestones: 0.4.0 Customer's dashboard , 0.5.0 Marketing Features Jan 9, 2018
@pkarw pkarw closed this as completed Feb 11, 2018
patzick pushed a commit that referenced this issue Jun 10, 2019
andrzejewsky pushed a commit that referenced this issue May 19, 2020
filrak pushed a commit that referenced this issue Jan 5, 2021
Apply changes to context to Boilerplate (#5276)
sethidden added a commit that referenced this issue Apr 5, 2024
Closes #11

This PR will break CI in repos that already use Changesets. You will need to update the lockfile so that breakword@1.0.6 is installed. 1.0.5 is still GPL licensed (bad) while MIT is 1.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants