Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

productPageVisited hook param type is incorrect #5997

Closed
3 of 7 tasks
rain2o opened this issue Jun 15, 2021 · 0 comments
Closed
3 of 7 tasks

productPageVisited hook param type is incorrect #5997

rain2o opened this issue Jun 15, 2021 · 0 comments
Assignees
Labels
1: Easy bug Bug reports VSF1 Issues in regards to VSF1
Milestone

Comments

@rain2o
Copy link
Contributor

rain2o commented Jun 15, 2021

Current behavior

In catalog-next/hook the definition for the productPageVisited hook declares the parameter type as a Category, but it should be Product.

const {
hook: productPageVisitedHook,
executor: productPageVisitedExecutor
} = createListenerHook<Category>()

Expected behavior

The parameter should be typed as Product

Steps to reproduce the issue

N/A, not a functional bug, just an incorrect type cast.

Version of Vue Storefront

  • Vue Storefront
  • Vue Storefront Next

Can you handle fixing this bug by yourself?

  • YES
  • NO

Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)

Pick one option.

  • This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

@rain2o rain2o added the bug Bug reports label Jun 15, 2021
@lukaszjedrasik lukaszjedrasik added the VSF1 Issues in regards to VSF1 label Jun 21, 2021
@Fifciu Fifciu added the 1: Easy label Jun 21, 2021
@lukaszjedrasik lukaszjedrasik added this to the 1.12.3 milestone Jun 22, 2021
Fifciu added a commit that referenced this issue Jun 24, 2021
…hook-param-type

fix: set correct type for productPageVisited hook param
@Fifciu Fifciu closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: Easy bug Bug reports VSF1 Issues in regards to VSF1
Projects
None yet
Development

No branches or pull requests

3 participants