Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(rules): Eslint 9 and flat config support #98

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

corbinu
Copy link

@corbinu corbinu commented Apr 20, 2024

Updates to eslint 9 and the new flat file config system

Resolves #93

@corbinu corbinu changed the title feature(rules): Eslint 9 and flat config support Resolves #93 feature(rules): Eslint 9 and flat config support Apr 20, 2024
@lukas-mertens
Copy link

lukas-mertens commented Jun 4, 2024

@corbinu I think it would be nice to add some docs / an example on how to use the new flat config. You should probably adopt the README a bit

@bryantmh
Copy link

bryantmh commented Jul 9, 2024

This PR appears to be working and has been sitting here for awhile. Any chance of getting it merged even as a beta? I'm currently working on updating a Vue 2 project to Vue 3 that's already on eslint 9, and have had to manually make some of these changes to get it working even in compat mode.

@derHodrig
Copy link

@KaelWD @johnleider could you please apply necessary steps to publish this as a beta version? So we the community can test it and bring it to some sort of release?

This tool might be very handy but is not usable for eslint 9 users. With a beta we could at least test it and if it works we could migrate faster, if not, no problem its beta. What's your opinion?

@shimizukawa
Copy link

FYI: I'm using this PR code in my project, applying it via @nuxt/eslint as follows.

install

yarn add https://github.com/corbinu/eslint-plugin-vuetify/

eslint.config.mjs

import vuetify from "eslint-plugin-vuetify/src/index.js";
import withNuxt from "./.nuxt/eslint.config.mjs";

export default withNuxt(
  {
    files: ['**/*.vue'],
    plugins: { vuetify },
    rules: {
      ...vuetify.configs.base.rules,
     'vuetify/no-deprecated-classes': '<SOME-VALUE>',
    },
  },
);

@johnleider johnleider requested a review from KaelWD July 31, 2024 15:18
@SmootherSpike
Copy link

SmootherSpike commented Aug 13, 2024

any updates when this will be merged? thanks for the updates and work

@johnleider johnleider added the enhancement New feature or request label Aug 13, 2024
@corbinu
Copy link
Author

corbinu commented Aug 13, 2024

Hello,

I am not going to be moving forward with using this plugin so if anybody else wants to take over the PR they are welcome to.

Corbin Uselton

@shimizukawa
Copy link

@corbinu I can take over, but what are the remaining tasks?

@corbinu
Copy link
Author

corbinu commented Aug 15, 2024

@shimizukawa Here is the one request I was given. Sorry that I can't do this right now.

@corbinu I think it would be nice to add some docs / an example on how to use the new flat config. You should probably adopt the README a bit

@shimizukawa
Copy link

@corbinu OK, then. I'll submit another PR to update the documentation.
@johnleider I think this PR can be merged without waiting for the documentation to be updated.

@shimizukawa
Copy link

@corbinu @johnleider I have created a PR #101 for documentation update. Please check it out.

@corbinu corbinu removed their assignment Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 9.x
8 participants