delay adding click-outside event handler until after v-app has been mounted #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyth64
pushed a commit
to schmidigital/vuetify
that referenced
this pull request
Mar 2, 2017
* 'master' of https://github.com/vuetifyjs/vuetify: (211 commits) enhancement for vuetifyjs#154 [release] 0.8.10 [build] 0.8.10 updates for vuetifyjs#141 added persistent prop for vuetifyjs#143 fix for vuetifyjs#142 fix for vuetifyjs#142 added missing style. Update Alert.vue updated tabs to properly use v-model added back preventDefault for tabs added ability for alert to be default not visible [release] 0.8.9 [build] 0.8.9 small tweaks bug fix for sidebar fix for vuetifyjs#134 fix for vuetifyjs#138 delay adding click-outside event handler until after v-app has been mounted (vuetifyjs#137) Fix wrong toolbar item active class name (vuetifyjs#133) ...
KaelWD
pushed a commit
that referenced
this pull request
Oct 28, 2018
* replaced `<code></code>` with markdown * replaced template strings with normal strings * removed unnecessary spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed on gitter. the bind() method of a directive can run before the component it's in has been mounted and added to the DOM, so install the click event handler after that.