Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VField): match chips line-height, center prepend/append #17175

Merged
merged 48 commits into from
May 19, 2023
Merged

fix(VField): match chips line-height, center prepend/append #17175

merged 48 commits into from
May 19, 2023

Commits on Apr 18, 2023

  1. fix(VField): v-field__input min-height should also consider line-height 

    fixes #16901
    @yuwu9145
    yuwu9145 committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    e9e73d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. chore: prevent padding to be negative

    @yuwu9145
    yuwu9145 committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    8a4cc8c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2023

  1. make input line-height match small chip's height

    @yuwu9145
    yuwu9145 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    9181d02 View commit details
    Browse the repository at this point in the history

  2. remove testing code

    @yuwu9145
    yuwu9145 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    ca78f0d View commit details
    Browse the repository at this point in the history

  3. chore: tweak

    @yuwu9145
    yuwu9145 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    c15926f View commit details
    Browse the repository at this point in the history

  4. keep fixing issue #15686

    @yuwu9145
    yuwu9145 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    023079d View commit details
    Browse the repository at this point in the history

  5. tweak

    @yuwu9145
    yuwu9145 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    16847bb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix-16901

    @yuwu9145
    yuwu9145 committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    6c562c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2023

  1. tweak

    @yuwu9145
    yuwu9145 committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    2780016 View commit details
    Browse the repository at this point in the history

  2. chore: fix failed cy test

    @yuwu9145
    yuwu9145 committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    4232179 View commit details
    Browse the repository at this point in the history

  3. chore: fix failed cy test

    @yuwu9145
    yuwu9145 committed Apr 30, 2023
    Configuration menu
    Copy the full SHA
    10b51a4 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. address review feedback

    @yuwu9145
    yuwu9145 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c33b2e8 View commit details
    Browse the repository at this point in the history

  2. use css flex to vertically center align icons

    @yuwu9145
    yuwu9145 committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c8387b7 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. chore: centralise label for chips mode

    @yuwu9145
    yuwu9145 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    a2241d2 View commit details
    Browse the repository at this point in the history

  2. chore: use translateY to guarantee label in middle

    @yuwu9145
    yuwu9145 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    70604c1 View commit details
    Browse the repository at this point in the history

  3. remove unnecessary var

    @yuwu9145
    yuwu9145 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    565093a View commit details
    Browse the repository at this point in the history

  4. apply margin to chip selection and input min-height considers these m… 

    …argins
    @yuwu9145
    yuwu9145 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3d58915 View commit details
    Browse the repository at this point in the history

  5. wip

    @yuwu9145
    yuwu9145 committed May 3, 2023
    Configuration menu
    Copy the full SHA
    5e228f4 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. field label align middle by default but align top for textarea

    @yuwu9145
    yuwu9145 committed May 4, 2023
    Configuration menu
    Copy the full SHA
    df48196 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. label align to top by default and override to middle in single line c… 

    …omponents
    @yuwu9145
    yuwu9145 committed May 5, 2023
    Configuration menu
    Copy the full SHA
    ee6a214 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. chips margin top/bottom should be same in outlined variant

    @yuwu9145
    yuwu9145 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    92fe2ae View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. refactor: make variables readable

    @KaelWD
    KaelWD committed May 15, 2023
    Configuration menu
    Copy the full SHA
    fe4cb89 View commit details
    Browse the repository at this point in the history

  2. remove label centre align logic from select comps as per review feedback

    @yuwu9145
    yuwu9145 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    4d2772e View commit details
    Browse the repository at this point in the history

  3. reduce input padding top/bottom to restore VTextField height to 56px

    @yuwu9145
    yuwu9145 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7053ded View commit details
    Browse the repository at this point in the history

  4. restor cy test

    @yuwu9145
    yuwu9145 committed May 15, 2023
    Configuration menu
    Copy the full SHA
    7c6e3e7 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. fix textarea cy test

    @yuwu9145
    yuwu9145 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a9c045b View commit details
    Browse the repository at this point in the history

  2. prepend-inner has same padding top/bottom as input

    @yuwu9145
    yuwu9145 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    2f6cd0b View commit details
    Browse the repository at this point in the history

  3. clearable aligns vertically in center

    @yuwu9145
    yuwu9145 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fbb87cf View commit details
    Browse the repository at this point in the history

  4. remove inline effect for prepend inner icon in solo & solo-filled var… 

    …iants
    @yuwu9145
    yuwu9145 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    edf157d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into fix-16901

    @KaelWD
    KaelWD committed May 16, 2023
    Configuration menu
    Copy the full SHA
    a260921 View commit details
    Browse the repository at this point in the history

  6. align prepend inner middle for filled variant

    @yuwu9145
    yuwu9145 committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c8f2c42 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. move label and inner icons inline with input for underlined

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    956bc33 View commit details
    Browse the repository at this point in the history

  2. input padding-bottom consider density calc for underlined

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    2ba1015 View commit details
    Browse the repository at this point in the history

  3. Only underlined needs inline inner icons

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    20c28e5 View commit details
    Browse the repository at this point in the history

  4. fix broken selector

    @KaelWD
    KaelWD committed May 17, 2023
    Configuration menu
    Copy the full SHA
    f40a86e View commit details
    Browse the repository at this point in the history

  5. fix single-line plain/underlined height

    @KaelWD
    KaelWD committed May 17, 2023
    Configuration menu
    Copy the full SHA
    4f53244 View commit details
    Browse the repository at this point in the history

  6. label & inner icons inline for plain variant

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    011ba8a View commit details
    Browse the repository at this point in the history

  7. introduce centerAffix prop to VField to make affix display correctly … 

    …in textarea
    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    2f555a3 View commit details
    Browse the repository at this point in the history

  8. Add api description for centerAffix

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    dc347a8 View commit details
    Browse the repository at this point in the history

  9. remove comma in api description

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    72a2e43 View commit details
    Browse the repository at this point in the history

  10. remove redundant label position logic which can be replaced by center… 

    …Affix
    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    18d27a7 View commit details
    Browse the repository at this point in the history

  11. remove redundant label position logic in VFileInput

    @yuwu9145
    yuwu9145 committed May 17, 2023
    Configuration menu
    Copy the full SHA
    6a44e20 View commit details
    Browse the repository at this point in the history

  12. fix underlined floating label position

    @KaelWD
    KaelWD committed May 17, 2023
    Configuration menu
    Copy the full SHA
    03d76c1 View commit details
    Browse the repository at this point in the history

  13. account for textarea auto-grow

    @KaelWD
    KaelWD committed May 17, 2023
    Configuration menu
    Copy the full SHA
    42bb52d View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Use centerAffix in VInput to align prepend/append with inner icons

    @yuwu9145
    yuwu9145 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    ad34586 View commit details
    Browse the repository at this point in the history

  2. label top consider v-field-padding-top for underlined and plain

    @yuwu9145
    yuwu9145 committed May 18, 2023
    Configuration menu
    Copy the full SHA
    90a8d40 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Make selection slot behaves the same as chips prop by default

    @yuwu9145
    yuwu9145 committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dc97708 View commit details
    Browse the repository at this point in the history

  2. Add selection slot class

    @yuwu9145
    yuwu9145 committed May 19, 2023
    Configuration menu
    Copy the full SHA
    98e5464 View commit details
    Browse the repository at this point in the history