-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VColorPicker): add eyedropper button when supported #17952
Merged
KaelWD
merged 9 commits into
vuetifyjs:dev
from
prashantsinghb:feat/14790-support-eye-dropper-for-color-picker
Aug 9, 2023
Merged
feat(VColorPicker): add eyedropper button when supported #17952
KaelWD
merged 9 commits into
vuetifyjs:dev
from
prashantsinghb:feat/14790-support-eye-dropper-for-color-picker
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelWD
requested changes
Aug 3, 2023
packages/vuetify/src/components/VColorPicker/VColorPickerPreview.tsx
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VColorPicker/VColorPickerPreview.tsx
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VColorPicker/VColorPickerPreview.tsx
Outdated
Show resolved
Hide resolved
Chrome has it on the left before the circle preview
We don't have one for the expand icon either, it's probably fine. |
KaelWD
changed the title
feat(VColorPickerPreview): Support eye dropper functionality.
feat(VColorPicker): add eyedropper button when supported
Aug 9, 2023
prashantsinghb
deleted the
feat/14790-support-eye-dropper-for-color-picker
branch
August 9, 2023 09:21
blalan05
pushed a commit
that referenced
this pull request
Oct 28, 2023
closes #14790 Co-authored-by: Kael <kaelwd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14790
Description
In EyeDropper API compatible browser, an icon will be displayed in VColorPicker to sample colors from their screens, including outside of the browser window.
Queries
Markup: