Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VColorPicker): add eyedropper button when supported #17952

Conversation

prashantsinghb
Copy link
Contributor

resolves #14790

Description

In EyeDropper API compatible browser, an icon will be displayed in VColorPicker to sample colors from their screens, including outside of the browser window.

Queries

  • Position of EyeDropper Icon in color picker?
  • Should EyeDropper icon be prop?

image

Markup:

<template>
  <div class="d-flex justify-space-around">
    <v-color-picker
      v-model="picker"
    ></v-color-picker>
  </div>
</template>
<script>
  export default {
    data () {
      return {
        picker: null,
      }
    },
  }
</script>

@KaelWD
Copy link
Member

KaelWD commented Aug 3, 2023

Position of EyeDropper Icon in color picker?

Chrome has it on the left before the circle preview

Should EyeDropper icon be prop?

We don't have one for the expand icon either, it's probably fine.

@prashantsinghb
Copy link
Contributor Author

Moved position of eyedropper to left before circle preview

image

@KaelWD KaelWD added this to the v3.4.0 (Blackguard) milestone Aug 9, 2023
@KaelWD KaelWD self-assigned this Aug 9, 2023
@KaelWD KaelWD changed the title feat(VColorPickerPreview): Support eye dropper functionality. feat(VColorPicker): add eyedropper button when supported Aug 9, 2023
@KaelWD KaelWD merged commit 3559698 into vuetifyjs:dev Aug 9, 2023
9 of 11 checks passed
@prashantsinghb prashantsinghb deleted the feat/14790-support-eye-dropper-for-color-picker branch August 9, 2023 09:21
blalan05 pushed a commit that referenced this pull request Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants