-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VMenu): allow enter keypress to work in textareas #19768
Merged
johnleider
merged 7 commits into
vuetifyjs:master
from
curtgrimes:fix/19767-menu-textarea-enter
May 13, 2024
Merged
fix(VMenu): allow enter keypress to work in textareas #19768
johnleider
merged 7 commits into
vuetifyjs:master
from
curtgrimes:fix/19767-menu-textarea-enter
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a `<v-menu />` with `:close-on-content-click="false"` contained a textarea, an enter press inside the textarea would do nothing and not produce a new line. Now, it will allow a new line to be typed into the textarea when pressing enter. This last worked in Vuetify v3.5.14 and was broken starting in v3.5.15. The fix for vuetifyjs#19519 in 85ba4a8 caused this issue. fixes vuetifyjs#19767
MajesticPotatoe
added
T: bug
Functionality that does not work as intended/expected
C: VMenu
VMenu
labels
May 8, 2024
johnleider
approved these changes
May 13, 2024
This was referenced Jun 11, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when a
<v-menu />
with:close-on-content-click="false"
contained a textarea, an enter press inside the textarea would do nothing and not produce a new line. Now, it will allow a new line to be typed into the textarea when pressing enter.This last worked in Vuetify v3.5.14 and was broken starting in v3.5.15. The fix for #19519 in 85ba4a8 caused this issue.
fixes #19767
Markup:
Before this fix, and in Vuetify v3.5.15 and after, enter cannot be typed in:
After this fix, the behavior matches the Vuetify <= v3.5.14 behavior and enter can be typed into the textarea: