Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add router option to navbar items (#22) #25

Merged
merged 3 commits into from
Dec 22, 2016
Merged

Add router option to navbar items (#22) #25

merged 3 commits into from
Dec 22, 2016

Conversation

spezzino
Copy link
Contributor

No description provided.

@johnleider
Copy link
Member

Looks good, just missing a few props on the router-link.

      active-class="navbar__item--active"
      v-bind:exact="item.href === '/'"
      v-bind:to="item.href"
      v-on:click.native="click()"
      v-else

@spezzino
Copy link
Contributor Author

@johnleider added missing properties in a new commit

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@johnleider johnleider merged commit fb78670 into vuetifyjs:master Dec 22, 2016
@lock
Copy link

lock bot commented Apr 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants