-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VTabs): RTL support for VTabs #6812
Conversation
Fixed few issues with VTabs in RTL mode.
Codecov Report
@@ Coverage Diff @@
## master #6812 +/- ##
=========================================
- Coverage 85.31% 85.22% -0.1%
=========================================
Files 298 298
Lines 7210 7220 +10
Branches 1803 1810 +7
=========================================
+ Hits 6151 6153 +2
- Misses 958 962 +4
- Partials 101 105 +4
Continue to review full report at Codecov.
|
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- This should be first rebased to next.
- Secondly you need to provide you full playground in the description so we are able to test.
- Third vtabs have already been converted to MD2 with real support so before (hence why the issues that were closed but don't seem fixed are there, as they have been fixed in 2.0)
I would suggest looking at what 2.0 has before moving forward with this. For the time being I'm marking this on hold and for review.
*next |
@MajesticPotatoe Thank you for your review... This should be first rebased to dev.
Secondly you need to provide you full playground in the description so we are able to test.
Third vtabs have already been converted to MD2 with real support so before (hence why the issues that were closed but don't seem fixed are there, as they have been fixed in 2.0)
|
@MajesticPotatoe Any further action required from me to get this going? |
@ram33 reviewing with team. In the meantime please rebase this to next. |
This Pull Request is being closed due to inactivity. Thank you for your contribution and interest in improving Vuetify! |
@johnleider So all the pull-requests should be rebased to next branch only... can't we get this fix on 1.5.x? |
Fixed few issues with VTabs in RTL mode.
Description
There are couple of issues with VTabs in RTL mode with pagination.
Initial tabs positioning not right. Tabs moved towards left onto pagination leaving empty space on right. - fixed
Prev/Next button clicks moving tabs in opposite direction - Fixed
Prev/Next buttons not hiding based on Tab scroll position - Fixed
Position active tab in visible portion of tabs on load - Not fixed.
Motivation and Context
We are using VTabs as menu bar in our application and without this Tabs are not functional/usable in RTL mode.
There are couple of issues logged. One of them is open and other are closed as no support at that moment or marked as fixed (but not actually fixed).
#6696
#4788
#5329
#6575
How Has This Been Tested?
I have used Playground.vue to test this.
None
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).