-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDataTable): change data-table scoped slot props structure #7585
Conversation
make it easier to use props in scoped slots
d003ead
to
f913205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## next #7585 +/- ##
==========================================
- Coverage 86.38% 86.36% -0.02%
==========================================
Files 328 328
Lines 8796 8794 -2
Branches 2219 2219
==========================================
- Hits 7598 7595 -3
- Misses 1105 1106 +1
Partials 93 93
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #7585 +/- ##
==========================================
- Coverage 85.68% 85.67% -0.02%
==========================================
Files 333 333
Lines 9090 9088 -2
Branches 2412 2412
==========================================
- Hits 7789 7786 -3
- Misses 1206 1207 +1
Partials 95 95
Continue to review full report at Codecov.
|
Hey @nekosaur, TravisBuddy Request Identifier: 9fb90ca0-aa6e-11e9-91b1-f106ceecf692 |
Description
previous structure of scoped slot props was geared towards ease of use internally when creating rows (
expand.on.input
,expand.props.value
). However this made things unnecessarily verbose when end users wanted to use expand/select functionality in scoped slots.Motivation and Context
ease of use for developers using scoped slots
How Has This Been Tested?
playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).