-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDatePicker): pick date range #8891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsseng
previously requested changes
Sep 8, 2019
packages/vuetify/src/components/VDatePicker/__tests__/VDatePicker.date.spec.ts
Outdated
Show resolved
Hide resolved
packages/vuetify/src/components/VDatePicker/__tests__/VDatePicker.date.spec.ts
Show resolved
Hide resolved
dsseng
changed the title
feat(vdatepicker): pick date range
feat(VDatePicker): pick date range
Sep 8, 2019
…ker.date.spec.ts Co-Authored-By: Dmitry Sharshakov <d3dx12.xx@gmail.com>
dsseng
suggested changes
Sep 8, 2019
dsseng
suggested changes
Sep 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add docs for this. Document new prop + add an example.
dsseng
added
the
S: needs docs update
The change requires an update to the documentation
label
Sep 8, 2019
dsseng
suggested changes
Sep 8, 2019
packages/docs/src/examples/date-pickers/intermediate/date-range.vue
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dmitry Sharshakov <d3dx12.xx@gmail.com>
dsseng
removed
the
S: needs docs update
The change requires an update to the documentation
label
Sep 9, 2019
dsseng
approved these changes
Sep 9, 2019
Daniel-Gherard
approved these changes
Sep 19, 2019
johnleider
approved these changes
Sep 24, 2019
MajesticPotatoe
pushed a commit
that referenced
this pull request
Sep 27, 2019
* feat(vdatepicker): pick date range fixes #1646 * test(vdatepicker): add unit test * Update packages/vuetify/src/components/VDatePicker/__tests__/VDatePicker.date.spec.ts Co-Authored-By: Dmitry Sharshakov <d3dx12.xx@gmail.com> * refactor(vdatepicker): fix based on review * refactor(vdatepicker): fix based on review * docs(vdatepicker): add docs for range prop * Update packages/docs/src/lang/en/components/DatePickers.json Co-Authored-By: Dmitry Sharshakov <d3dx12.xx@gmail.com> * docs(vdatepicker): fix based on review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1646
Description
Allow datepicker to pick range.
By add new prop "Range", a workaround is provided to handle range picking.
Motivation and Context
#1646
How Has This Been Tested?
visually and unit
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).