Package "stream" is misleadingly named #9
Comments
|
great catch, I thought about, buffer is too generic though, I promise to rename it if you come up with a great name :-) |
|
StreamBuffer |
|
@bradgignac too long |
|
streambuf? |
|
oxybuf? |
|
retry? gather? |
|
buffer/buffer.go - Buffer request into memory or disk Reads the entire request and response into buffer, optionally buffering it to disk for large requests. Ex. buffer up to 2MB in memory buffer sounds great! when I'm reading the code as buffer. code shift for readability
haven't read all the code yet, but I will PR the shift in code if sounds good in use |
This handles the issue: #9 It is a better name and helps clarify what the intent and function of this object is.
Parse the MIME media type from the Content-Type header
This handles the issue: #9 It is a better name and helps clarify what the intent and function of this object is.
This handles the issue: #9 It is a better name and helps clarify what the intent and function of this object is.
…#45) * Renamed Stream to Buffer This handles the issue: #9 It is a better name and helps clarify what the intent and function of this object is. * Forked the original stream into Buffer. * Fixed a build break * Simplified stream to be pass-through for now. * Most UTs for stream expect StatusOk as return code * More updates towards allowing streaming 1. Initial run at the feedback received on the code review, namely, updated all comments/docs to say "buffer" in the buffer part of the code, and fixed the mistaken package "steam" to "stream" 2. In fwd.go, replaced RoundTripper with ReverseProxy when the stream flag is provided. Not sure yet ReverseProxy won't buffer and wait for EOF to flush bytes down to the client but having a httpStreamingForwarded as a playground, ensures the working version of the forwarded isn't affected by any bugs/mistakes I introduce. * Finished up the httpStreamingForwarder. * Externalize FlushInterval, with a default, and add a URL connect/disconnect listener. * Make URL to listener, a pointer so listeners can track them correctly. * Go fmt * Updated documentation for stream * Rename Stream test correctly. * Rebased against master * Merge artifact removed * Added a chunked transfer encoding unit test.
|
@archisgore renamed the package, maybe this could be closed? |
|
I'm closing it. Please reopen if something is amiss. |
github.com/mailgun/oxy/stream seems to do the opposite of streaming. "Reads the entire request and response into buffer, [...]"
Maybe it should really be named buffer?
The text was updated successfully, but these errors were encountered: