Do not forward websocket close codes that are invalid on the wire #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the test failure related? It doesn't look like it to me. |
jd3nn1s
force-pushed
the
master
branch
7 times, most recently
from
882e036
to
8f6b928
Compare
|
Another try? I'm also looking forward for this fix :) |
jd3nn1s
force-pushed
the
master
branch
2 times, most recently
from
5f533f9
to
c9988e5
Compare
|
I've actually retried 10 times; it failed every time. Looks like there are a few different combinations of test failure. |
|
I fix the problem on master, could you rebase? |
|
This is passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133
Mirrors the behavior of AWS' ALB. If the client TCP connection closes without a close frame, just close the underlying TCP connection gracefully.