Bring back the context logger #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was left from long ago.
Closed
archisgore
reviewed
Oct 12, 2017
forward/fwd.go
Outdated
| @@ -130,7 +141,7 @@ type UrlForwardingStateListener func(*url.URL, int) | |||
| // New creates an instance of Forwarder based on the provided list of configuration options | |||
| func New(setters ...optSetter) (*Forwarder, error) { | |||
| f := &Forwarder{ | |||
| httpForwarder: &httpForwarder{flushInterval: time.Duration(100) * time.Millisecond}, | |||
| httpForwarder: &httpForwarder{flushInterval: time.Duration(100) * time.Millisecond, log: log.New()}, | |||
There was a problem hiding this comment.
I would prefer this to be: log.StandardLogger()
Which is where all direct logging calls to the log package get routed to. That will preserve any behavior where someone has modified the StandardLogger globally and expects the current behavior.
There was a problem hiding this comment.
Yes, that sounds good! Incidentally, that would solve some of our problems, too. :)
This means the behaviour will be the same as before, e.g. global logrus settings will be set on the forward logger by default.
|
I'm good with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #85, this brings back the "context logger" that used to be part of oxy.
This allows passing a custom logger to oxy that can be changed as appropriate for applications.
This starts with the
forwardpackage. Let's review that first, and when we're happy with the design I'll add similar changes for the other packages to this PR.Usage is currently as follows: