Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependecy updates #6

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Dependecy updates #6

merged 2 commits into from
Dec 14, 2021

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Dec 14, 2021

Description

bumped k8 to 1.22.4 + cert-manager 1.6.1

This introduces some changes as with 1.6.0+ cert-manager is v1
https://github.com/jetstack/cert-manager/releases/tag/v1.6.0

I also changed the makefile to grab the required bins for testing


As for testing I validated this by running

TEST_ZONE_NAME=freightapp.co. make test

This passed without issues

Related Issues

#5

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ddymko ddymko added the dependencies Pull requests that update a dependency file label Dec 14, 2021
@ddymko ddymko changed the title Dependcy updates Dependecy updates Dec 14, 2021
Copy link
Contributor

@ErwinsExpertise ErwinsExpertise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Tested & works

@ErwinsExpertise ErwinsExpertise merged commit db1791b into vultr:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants