Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests & CI checks #122

Merged
merged 9 commits into from
Jan 6, 2021
Merged

Unit tests & CI checks #122

merged 9 commits into from
Jan 6, 2021

Conversation

ddymko
Copy link
Contributor

@ddymko ddymko commented Jan 5, 2021

Description

  • Adding gofmt and golint checks to PRs
  • Added missing unit tests and more tests for govultr_test.go
  • Fixed typo in URI for detach private networks in instances (bug)

Related Issues

n/a

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #122 (b7267c4) into master (e1ebd44) will increase coverage by 5.86%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   49.14%   55.00%   +5.86%     
==========================================
  Files          23       23              
  Lines        1168     1169       +1     
==========================================
+ Hits          574      643      +69     
+ Misses        348      264      -84     
- Partials      246      262      +16     
Impacted Files Coverage Δ
user.go 50.00% <0.00%> (-2.95%) ⬇️
govultr.go 90.58% <100.00%> (+10.35%) ⬆️
instance.go 55.84% <100.00%> (+14.71%) ⬆️
bare_metal_server.go 52.94% <0.00%> (+8.82%) ⬆️
load_balancer.go 50.72% <0.00%> (+10.14%) ⬆️
network.go 51.35% <0.00%> (+21.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ebd44...b7267c4. Read the comment docs.

@ddymko ddymko changed the title go checks Unit tests & CI checks Jan 5, 2021
@ddymko ddymko merged commit a9bb004 into vultr:master Jan 6, 2021
@ddymko ddymko deleted the go-checks branch January 6, 2021 18:03
This was referenced Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants