feat(commandpost): add strict: true option to tsconfig.json

Author: vvakame

lib/argument.ts

@@ -1,5 +1,3 @@
-"use strict";
-
 // jsdoc, see constructor.
 export default class Argument {
     /** argument name */

lib/command.ts

@@ -1,5 +1,3 @@
-"use strict";
-
 import Option from "./option";
 import Argument from "./argument";
 
@@ -118,7 +116,7 @@ export default class Command<Opt, Arg> {
      */
     constructor(name: string) {
         let args = name.split(/\s+/);
-        this.name = args.shift();
+        this.name = args.shift()!;
 
         let findOptional = false;
         let findVariadic = false;
@@ -389,7 +387,7 @@ export default class Command<Opt, Arg> {
         let rest: string[] = [];
         let processedOptions: Option[] = [];
         while (args.length !== 0) {
-            let arg = args.shift();
+            let arg = args.shift()!;
             if (arg === "--") {
                 rest = rest.concat(args);
                 break;
@@ -443,7 +441,7 @@ export default class Command<Opt, Arg> {
         let result: string[] = [];
         for (let i = 0; i < args.length; i++) {
             let arg = args[i];
-            let lastOpt: Option;
+            let lastOpt: Option | undefined;
             if (0 < i) {
                 lastOpt = this.options.filter(opt => opt.is(args[i - 1]))[0];
             }

lib/index.ts

@@ -1,5 +1,3 @@
-"use strict";
-
 try {
     // optional
     require("source-map-support").install();
@@ -24,8 +22,6 @@ export { Command, Option, Argument };
  * @returns {Command<Opt, Arg>}
  */
 export function create<Opt, Arg>(cmdName: string): Command<Opt, Arg> {
-    "use strict";
-
     return new Command<Opt, Arg>(cmdName);
 }
 
@@ -36,8 +32,6 @@ export function create<Opt, Arg>(cmdName: string): Command<Opt, Arg> {
  * @returns {Promise<{}>}
  */
 export function exec(cmd: Command<any, any>, argv: string[]): Promise<{}> {
-    "use strict";
-
     return Promise
         .resolve(null)
         .then(() => {

lib/option.ts

@@ -1,5 +1,3 @@
-"use strict";
-
 import * as utils from "./utils";
 
 // jsdoc, see constructor.
@@ -34,9 +32,9 @@ export default class Option {
         this.no = flags.indexOf("-no-") === -1;
         let splittedFlags = flags.split(/[ ,|]+/);
         if (splittedFlags.length > 1 && !/^[[<]/.test(splittedFlags[1])) {
-            this.short = splittedFlags.shift();
+            this.short = splittedFlags.shift()!;
         }
-        this.long = splittedFlags.shift();
+        this.long = splittedFlags.shift()!;
         this.description = description || "";
         if (typeof this.defaultValue === "undefined") {
             if (this.required || this.optional) {

lib/utils.ts

@@ -1,14 +1,10 @@
-"use strict";
-
 /**
  * calc max length of strs.
  * @param strs
  * @returns {number}
  * @private
  */
 export function maxLength(strs: string[]): number {
-    "use strict";
-
     return strs.map(str => str.length).reduce((p, c) => Math.max(p, c), 0);
 }
 
@@ -21,8 +17,6 @@ export function maxLength(strs: string[]): number {
  * @private
  */
 export function pad(str: string, length: number, pad = " "): string {
-    "use strict";
-
     if (length <= str.length) {
         return str;
     }
@@ -42,8 +36,6 @@ export function pad(str: string, length: number, pad = " "): string {
  * @private
  */
 export function chainToLowerCamelCase(str: string): string {
-    "use strict";
-
     let nextCamel = false;
     return str
         .split("")

tsconfig.json

@@ -9,12 +9,10 @@
         "types": [
             "node",
             "mocha"
-        ],
-        "noImplicitAny": true,
-        "strictNullChecks": false,
+		],
+		"strict": true,
         "noFallthroughCasesInSwitch": true,
         "noImplicitReturns": true,
-        "noImplicitThis": true,
         "noUnusedLocals": true,
         "noUnusedParameters": true,
         "experimentalDecorators": true,
@@ -38,5 +36,5 @@
     ],
     "exclude": [
         "node_modules"
-    ]
-}
+	]
+}