Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Configurators that don't make panic when runs on locally #6

Merged
merged 1 commit into from
Apr 7, 2020
Merged

refactor Configurators that don't make panic when runs on locally #6

merged 1 commit into from
Apr 7, 2020

Conversation

vvakame
Copy link
Owner

@vvakame vvakame commented Apr 7, 2020

fixes #5

@vvakame vvakame requested a review from sinmetal April 7, 2020 06:49
@vvakame vvakame force-pushed the refactor-configurator branch 2 times, most recently from d666a4c to 388cb1f Compare April 7, 2020 07:04
@sinmetal
Copy link
Collaborator

sinmetal commented Apr 7, 2020

CI failed, but looks good

@vvakame vvakame merged commit e4e83dc into master Apr 7, 2020
@vvakame vvakame deleted the refactor-configurator branch April 7, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinmetal sinmetal sinmetal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run locally
2 participants
@vvakame @sinmetal