Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Want to know the name of a person who created PR #3

Closed
trknhr opened this issue Jun 10, 2019 · 2 comments
Closed

Want to know the name of a person who created PR #3

trknhr opened this issue Jun 10, 2019 · 2 comments
Assignees
@vvatanabe
Labels
good first issue Good for newcomers

Comments

@trknhr
Copy link

trknhr commented Jun 10, 2019 •
edited
Loading

Hi. it's a very useful library. I'm going to use it in my team.

But for now it shows only the name of a person who merged the PR in the change log.

I think it's better to show the name of a person creating the PR because it becomes one of the motivation to create new feature/bugfix for developers.

Please consider it.

Thank you.
@vvatanabe vvatanabe self-assigned this Jun 10, 2019
@vvatanabe vvatanabe added the good first issue Good for newcomers label Jun 10, 2019
@vvatanabe
Copy link
Owner

Thanks for the feedback.

I also think that it is better, and ghch as this library's origin shows the PR's creator. I would like to be compatible with the origin as much as possible.

I accept your suggestion and change the specs that way.

vvatanabe added a commit that referenced this issue Jun 10, 2019
@vvatanabe
change mkdown template (#3)
9bc7782
@vvatanabe vvatanabe mentioned this issue Jun 10, 2019
Merged
vvatanabe added a commit that referenced this issue Jun 10, 2019
@vvatanabe
Merge pull request #4 from vvatanabe/patch-3
ded199b 
Want to know the name of a person who created PR (#3)
vvatanabe added a commit that referenced this issue Jun 10, 2019
@vvatanabe
Checking in changes prior to tagging of version v0.2.0
f1ef20c 
## [v0.2.0](v0.1.0...v0.2.0) (2019-06-11)

* Keep the display order pull request in changelog (#5) [#6](#6) ([vvatanabe](https://github.com/vvatanabe))
* Want to know the name of a person who created PR (#3) [#4](#4) ([vvatanabe](https://github.com/vvatanabe))
@vvatanabe
Copy link
Owner

@1984weed Done! Published v0.2.0. Plz update go get -u github.com/vvatanabe/gbch or install from release page https://github.com/vvatanabe/gbch/releases/tag/v0.2.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvatanabe vvatanabe

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trknhr @vvatanabe