Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dset #37

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Upgrade dset #37

merged 2 commits into from
Sep 12, 2023

Conversation

yosiat
Copy link
Contributor

@yosiat yosiat commented Sep 12, 2023

@yosiat
Copy link
Contributor Author

yosiat commented Sep 12, 2023

@vweevers I saw that CI is not maintained and testing against old node.js versions, if you want I can do PR (or push commit to this PR) to migrate to github-actions.

@vweevers
Copy link
Owner

I saw that CI is not maintained and testing against old node.js versions, if you want I can do PR (or push commit to this PR) to migrate to github-actions.

A separate PR for that is certainly welcome, thank you! However, updating CI and dropping Node.js versions does involve a major bump, so I prefer to first land this vulnerability fix in a semver-patch release.

What is the breaking change in dset v3.0.0 and does it affect lento?

@vweevers
Copy link
Owner

What is the breaking change in dset v3.0.0 and does it affect lento?

Per https://github.com/lukeed/dset/releases/tag/v3.0.0, the only relevant change is the non-default export, so we're good.

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Sep 12, 2023
@vweevers vweevers merged commit 1053158 into vweevers:master Sep 12, 2023
@vweevers
Copy link
Owner

Published as 2.4.1. Thank you!

@yosiat yosiat deleted the upgrade-dset branch September 12, 2023 19:14
@yosiat
Copy link
Contributor Author

yosiat commented Sep 12, 2023

Thanks for the quick merge & release!

I did PR for Github Actions - #38, I think you need to approve the run for me, so I can test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants