Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-upgrade syntax via pyupgrade #158

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Auto-upgrade syntax via pyupgrade #158

merged 2 commits into from
Apr 13, 2022

Conversation

vwxyzjn
Copy link
Owner

@vwxyzjn vwxyzjn commented Apr 10, 2022

Description

This PR automatically upgrades the python syntax via pyupgrade

Types of changes

  • New feature

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the documentation and previewed the changes via mkdocs serve.

@vercel
Copy link

vercel bot commented Apr 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vwxyzjn/cleanrl/8xLmthC27DiM1cW6WsSNo6cE3o1V
✅ Preview: https://cleanrl-git-introduce-pyupgrade-vwxyzjn.vercel.app

@gitpod-io
Copy link

gitpod-io bot commented Apr 10, 2022

@vwxyzjn vwxyzjn mentioned this pull request Apr 10, 2022
Closed
19 tasks
dosssman
dosssman approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@dosssman dosssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the upgrade.
Despite its deprecation since python2.7, I always wondering why we keep seeing super(, self).init() in open source code. Change is slow but steady.

@vwxyzjn
Copy link
Owner Author

vwxyzjn commented Apr 13, 2022

Yep yep. This is a non-performance impacting change. Merging now.

@vwxyzjn vwxyzjn merged commit b403a4b into master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosssman dosssman dosssman approved these changes

@yooceii yooceii Awaiting requested review from yooceii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwxyzjn @dosssman