Merge pull request #7 from aviv/master

Detect `pdb.set_trace`, add test for `set_trace` calls

flake8_debug/plugin.py

@@ -17,6 +17,9 @@ def visit_Call(self, node: ast.Call) -> None:
             if (
                 isinstance(node.func, ast.Name)
                 and node.func.id == error.func_name
+            ) or (
+                isinstance(node.func, ast.Attribute)
+                and node.func.attr == error.func_name
             ):
                 self.issues.append((node.lineno, node.col_offset, error().msg))
 

requirements-dev.txt

@@ -1,5 +1,5 @@
 black==22.12.0
-flake8==4.0.1
+flake8>=4.0.1
 pytest==7.0.1
 pytest-cov==3.0.0
 coverage==5.3

requirements.txt

@@ -1,2 +1,2 @@
-flake8==4.0.1
+flake8>=4.0.1
 astpretty==2.1.0

tests/flake8_debug_test.py

@@ -8,6 +8,7 @@
     PrintError,
     BreakpointError,
     BreakpointHookError,
+    PdbError,
 )
 from flake8_debug.plugin import NoDebug
 
@@ -77,3 +78,19 @@ def test_present_multiple_breakpointhooks():
     ) == tuple(
         _out(line, column=5, err=BreakpointHookError()) for line in (3, 4)
     )
+
+
+def test_present_set_trace():
+    assert _plugin_results(
+        'def f():\n    import pdb\n    pdb.set_trace()'
+    ) == (
+        _out(line=3, column=5, err=PdbError()),
+    )
+
+
+def test_present_bare_set_trace():
+    assert _plugin_results(
+        'def f():\n    from pdb import set_trace\n    set_trace()'
+    ) == (
+        _out(line=3, column=5, err=PdbError()),
+    )