Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for handling validations of rating #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

vyomrastogi
Copy link
Owner

@vyomrastogi vyomrastogi commented Jan 16, 2021

Changes include :

  • Addition of @Validted and @Valid annotation in controller
  • Test case to validate error message when rating is not present in request
  • Additional handler in ExceptionHandler for handling validation scenario
  • Refactor in service class to have common method to retrieve movie by title

@AmalesanS
I added some changes, feel free to take a look whenever you get time

PS: a lot of changes are showing up because of auto formatting

@AmalesanS
Copy link
Collaborator

@vyomrastogi Hi, I pulled the latest code and all the test cases are passing. I can also see you have completed the rest of the AC also. I like your commitment. If we had little more time, we could be able to complete this yesterday. I like your coding style and learnt a lot from you and am i sure, the experience will help me. Looking forward to pair program with you in the up-coming sessions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants