Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T905: Delete old op-mode command show remote-config #87

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

The op-mode command show remote-config did not work for several years. Since it uses the old backend, we should delete it now. Will be redefined if necessary with a separate task, PR

vyos@r1:~$ show remote-config

  Invalid command: show remote-config [invalid]

vyos@r1:~$ show remote-config

  Incomplete command: show remote-config

vyos@r1:~$

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Delete old command

Related Task(s)

Related PR(s)

Component(s) name

show

Proposed changes

How to test

delete this command:

vyos@r1:~$ show remote-config 

  Invalid command: show remote-config [invalid]
      
vyos@r1:~$ show remote-config 

  Incomplete command: show remote-config

vyos@r1:~$ 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

The op-mode command `show remote-config` did not work for several
years. Since it uses the old backend we should delete it now.
Will be redefined if necessary with a separate task, PR

```
vyos@r1:~$ show remote-config

  Invalid command: show remote-config [invalid]

vyos@r1:~$ show remote-config

  Incomplete command: show remote-config

vyos@r1:~$

```
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team January 14, 2024 23:53
@sever-sever sever-sever requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for dmbaturin, sarthurdev, zdc, jestabro, c-po and a team January 14, 2024 23:53
@sever-sever
Copy link
Member Author

@Mergifyio backport sagitta

Copy link

mergify bot commented Jan 15, 2024

backport sagitta

✅ Backports have been created

@c-po c-po merged commit 6a0b841 into vyos:current Jan 15, 2024
6 of 8 checks passed
sever-sever added a commit that referenced this pull request Jan 18, 2024
T905: Delete old op-mode command show remote-config (backport #87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants