Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipsec prefix: T4275: Incorrect val_help for local/remote prefix in site-to-site ipsec vpn #1237

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

srividya0208
Copy link
Contributor

Change Summary

It accepts network as the input value but the completion help is showing ip address

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

ipsec

Proposed changes

Previousconfig:

vyos@vyos# set vpn ipsec site-to-site peer x.x.x.x tunnel x local prefix
Possible completions:
   <x.x.x.x>    Local IPv4 prefix
   <h:h:h:h:h:h:h:h>
                Local IPv6 prefix

New config:

vyos@vyos# set vpn ipsec site-to-site peer x.x.x.x tunnel 1 local prefix
Possible completions:
   <x.x.x.x/x>  Local IPv4 prefix
   <h:h:h:h:h:h:h:h/x>
                Local IPv6 prefix

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

It accepts network as the input value but the completion help is showing
ip address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants