Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipsec prefix: T4275: Fix for prefix val_help of remote-access and s2s vpn #1240

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

srividya0208
Copy link
Contributor

Change Summary

It accepts network as the input value but the completion help is showing
ip address in other section also(part of the previous commit)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

ipsec vpn

Proposed changes

Existing:

vyos@vyos# set vpn ipsec remote-access pool test prefix
Possible completions:
   <x.x.x.x>    Local IPv4 pool prefix
   <h:h:h:h:h:h:h:h>
                Local IPv6 pool prefix

vyos@vyos# set vpn ipsec remote-access pool test exclude
Possible completions:
   <x.x.x.x>    Local IPv4 pool prefix exclusion
   <h:h:h:h:h:h:h:h>
                Local IPv6 pool prefix exclusion
Remote prefix:

vyos@vyos# set vpn ipsec site-to-site peer 172.21.0.2 tunnel 0 remote prefix
Possible completions:
   <x.x.x.x>    Remote IPv4 prefix
   <h:h:h:h:h:h:h:h>
                Remote IPv6 prefix

Proposed:

vyos@vyos# set vpn ipsec site-to-site peer 172.21.0.2 tunnel 0 remote prefix
Possible completions:
   <x.x.x.x/x>    Remote IPv4 prefix
   <h:h:h:h:h:h:h:h/h>
                Remote IPv6 prefix

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

… vpn

It accepts network as the input value but the completion help is showing
ip address, continuation of previous commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants