Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geneve: T4366: prevent interface re-creation when not required #1286

Merged
merged 1 commit into from Apr 28, 2022
Merged

geneve: T4366: prevent interface re-creation when not required #1286

merged 1 commit into from Apr 28, 2022

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 18, 2022

Change Summary

Changing the geneve interface description does destroy the interface on the
kernel level - this should be avoided as it's ... stupid!

(cherry picked from commit 3cbe787)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

  • geneve

Proposed changes

How to test

smoketests

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
geneve: T4366: prevent interface re-creation on nasic parameter change
6bb409f 
Changing the geneve interface description does destroy the interface on the
kernel level - this should be avoided as it's ... stupid!

(cherry picked from commit 3cbe787)
@c-po c-po changed the title geneve: T4366: prevent interface re-creation on nasic parameter change geneve: T4366: prevent interface re-creation on basic Apr 18, 2022
@c-po c-po changed the title geneve: T4366: prevent interface re-creation on basic geneve: T4366: prevent interface re-creation when not required Apr 26, 2022
@c-po c-po merged commit 2a2bb78 into vyos:equuleus Apr 28, 2022
@c-po c-po deleted the t4633-geneve-equuleus branch May 8, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@sever-sever sever-sever sever-sever approved these changes

@DmitriyEshenko DmitriyEshenko Awaiting requested review from DmitriyEshenko

@dmbaturin dmbaturin Awaiting requested review from dmbaturin

@zdc zdc Awaiting requested review from zdc

Assignees

@c-po c-po

Labels
None yet
Milestone
No milestone
3 participants
@c-po @jestabro @sever-sever