Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webproxy: T4468: Fix regex for squidguard source-group #1363

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Jun 16, 2022

Change Summary

Fix regex for webproxy squidguard source-group

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

webproxy

Proposed changes

How to test

Before fix:

vyos@r14# set service webproxy url-filtering squidguard source-group fdsf

  
  
  URL-filter source-group cannot start with a number!
  Value validation failed
  Set failed

After fix:

vyos@r14# set service webproxy url-filtering squidguard source-group fdsf
[edit]
vyos@r14#

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po merged commit fc5c0d5 into vyos:current Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants