Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: T4456: support listening on specified interface (equuleus) #1390

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 4, 2022

Change Summary

When clients only use DHCP for interface addressing we can not bind NTPd to
an address - as it will fail if the address changes. This commit adds support
to bind ntpd to a given interface in addition to a given address.

set system ntp interface <name>

(cherry picked from commit 6732df1)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Integrated Smoketests

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

When clients only use DHCP for interface addressing we can not bind NTPd to
an address - as it will fail if the address changes. This commit adds support
to bind ntpd to a given interface in addition to a given address.

set system ntp interface <name>

(cherry picked from commit 6732df1)
It makes no sense to test against a VRF that might not exist at all.

(cherry picked from commit 171b224)
@c-po c-po requested a review from UnicronNL July 4, 2022 18:41
@c-po c-po changed the title ntp: T4456: support listening on specified interface ntp: T4456: support listening on specified interface (equuleus) Jul 5, 2022
@c-po c-po merged commit 7b99859 into vyos:equuleus Jul 7, 2022
@c-po c-po deleted the t4456-ntp-equuleus branch October 18, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants