T5011: Set default values for min_mtu max_mtu #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some interface drivers don't support/provide min_mtu and max_mtu values For example VyOS in docker container with 'veth' driver on some platforms As a workarund add default values for min/max MTU for calculations and pass function "verify_mtu(config)" (cherry picked from commit 87fb9be)
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro and
c-po
and removed request for
a team
c-po
approved these changes
Feb 20, 2023
jestabro
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Some interface drivers don't support/provide min_mtu and max_mtu values For example VyOS in a docker container with 'veth' driver on some platforms
As a workaround add default values for min/max MTU for calculations and pass function "verify_mtu(config)"
(cherry picked from commit 87fb9be)
Types of changes
Related Task(s)
Component(s) name
Proposed changes
How to test
Checklist: