Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T5097: show interfaces should reflect cleared counters #1911

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Mar 24, 2023

Change Summary

'show interfaces counters' correctly displays counter stats after a call to 'clear interfaces counters', however, 'show interfaces detail' does not. Add missing update to counter stats.

In the rewrite of vyatta-show-interfaces.pl to show_interfaces.py, one update of counters to reflect a call to 'clear counters' was dropped; the mistake persisted in the update of show_interfaces.py to interfaces.py.

Fix is here for 1.4 for interfaces.py.
Fix for 1.3 for show_interface.py is PR:
#1912

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

'show interfaces counters' correctly displays counter stats after a call
to 'clear interfaces counters', however, 'show interfaces detail' does
not.  Add missing update to counter stats.
@jestabro jestabro self-assigned this Mar 24, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team March 24, 2023 00:29
@c-po c-po merged commit 19ff8d4 into vyos:current Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants