interfaces: T4885: add 'clear interfaces counters' to op-mode #1916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Note: this will need to be merged after
vyos/vyatta-op#59
to avoid conflicting templates.
The functions
clear_counters
andreset_counters
were originally translated from Perl to Python inoperational.py
, however, they had errors and were never exposed in op-mode. Add fix; add to op-modeinterfaces.py
; add op-mode-defs.Note that
reset counters
was never exposed in vyatta-op: the 'reset' function removes the cached values (from a previous clear), returning to the raw counters of '/sys/class/net/ifname/statistics'. It is a question as to whether this is useful; this PR fixes the reset function but does not expose it, focusing only on the useful 'clear' function. Reset is trivial to add if desired.Types of changes
Related Task(s)
Component(s) name
Proposed changes
How to test
Checklist: