Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T4939: backport VRRP startup delay #1951

Merged
merged 2 commits into from
Apr 12, 2023
Merged

T4939: backport VRRP startup delay #1951

merged 2 commits into from
Apr 12, 2023

Conversation

fett0
Copy link
Contributor

@fett0 fett0 commented Apr 11, 2023

Change Summary

this is a backport feature 1.4.X to VRRP , it would give more time/delay to start the process

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

vrrp

Proposed changes

How to test

we would see this change in global_defs :

global_defs {
    dynamic_interfaces
    script_user root
    vrrp_startup_delay 60
    notify_fifo /run/keepalived/keepalived_notify_fifo
    notify_fifo_script /usr/libexec/vyos/system/keepalived-fifo.py
}

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 11, 2023 18:50
data/templates/vrrp/keepalived.conf.tmpl Outdated Show resolved Hide resolved
# commit changes
self.cli_commit()

# Check Global parameters
config = getConfig(f'global_defs')
self.assertIn(f'vrrp_startup_delay {startup_delay}', config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check this test in 1.3 node?

@dmbaturin dmbaturin merged commit 30263ab into vyos:equuleus Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants