dhcp: T5846: Refactor and simplify DUID definition #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
c-po
and removed request for
a team
c-po
requested changes
Dec 20, 2023
12 tasks
indrajitr
force-pushed
the
duid-refactor-T5846
branch
2 times, most recently
from
714226c
to
24fdf15
Compare
12 tasks
c-po
approved these changes
Dec 21, 2023
| <!-- include start from interface/duid.xml.i --> | ||
| <leafNode name="duid"> | ||
| <properties> | ||
| <help>DHCP unique identifier (DUID) to be sent by DHCP client</help> |
There was a problem hiding this comment.
DHCP unique identifier (DUID) to be sent by client second DHCP word is redundant.
Refactor DUID XML definition in conf-mode to be reusable. Additionally, remove explicit call to a separate validator `ipv6-duid` and inline the regex into the XML definition.
c-po
force-pushed
the
duid-refactor-T5846
branch
from
24fdf15
to
51e7832
Compare
c-po
approved these changes
Dec 21, 2023
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor DUID XML definition in conf-mode to be reusable. Additionally, remove explicit call to a separate validator
ipv6-duidand inline the regex into the XML definition.Types of changes
Related Task(s)
Related PR(s)
dhcp client/server
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: