Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmp: 5856: fix service removal error #2683

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 24, 2023

Change Summary

When deleting SNMP from CLI the 'delete' key was not honored in the config dictionary, leading to a false process startup causing the following error:

Job for snmpd.service failed because the control process exited with error code. See "systemctl status snmpd.service" and "journalctl -xeu snmpd.service" for details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

cpo@LR1.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_snmp.py
test_snmp_basic (__main__.TestSNMPService.test_snmp_basic) ... ok
test_snmpv3_md5 (__main__.TestSNMPService.test_snmpv3_md5) ... ok
test_snmpv3_sha (__main__.TestSNMPService.test_snmpv3_sha) ... ok

----------------------------------------------------------------------
Ran 3 tests in 25.045s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

When deleting SNMP from CLI the 'delete' key was not honored in the config
dictionary, leading to a false process startup causing the following error:

Job for snmpd.service failed because the control process exited with error code.
See "systemctl status snmpd.service" and "journalctl -xeu snmpd.service" for details.
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team December 24, 2023 13:05
@sever-sever sever-sever merged commit 8e6da6b into vyos:current Dec 24, 2023
7 of 8 checks passed
@c-po
Copy link
Member Author

c-po commented Dec 24, 2023

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Dec 24, 2023

backport sagitta

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Dec 24, 2023
snmp: 5856: fix service removal error (backport #2683)
@c-po c-po deleted the snmp-T5865 branch December 25, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants