Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image-tools: T5923: update system_console.py for new GRUB file structure #2818

Merged
merged 1 commit into from
Jan 16, 2024
Merged

image-tools: T5923: update system_console.py for new GRUB file structure #2818

merged 1 commit into from
Jan 16, 2024

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jan 13, 2024 •
edited by c-po
Loading

Change Summary

The config-mode script system_console.py has no effect when attempting to update grub.cfg for changes to:
set system console device ttyS0 speed
due to the revised organization of GRUB scripts in T4516.

Add utility function to update GRUB var console_speed and adjust as needed for compatibility mode.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro
image-tools: T5923: update system_console.py for new GRUB file structure
5ceaff2 
Add util function to set serial console speed in accordance with revised
GRUB file structure; in keeping with the intentions of the config_mode
script, adjust the GRUB var 'console_speed' to only modify ttyS0.
@jestabro jestabro self-assigned this Jan 13, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc and sever-sever and removed request for a team January 13, 2024 04:56
@vyosbot vyosbot requested a review from c-po January 13, 2024 04:56
@dmbaturin dmbaturin merged commit bf08f0f into vyos:current Jan 16, 2024
8 checks passed
@c-po
Copy link
Member

c-po commented Jan 17, 2024

@Mergifyio backport sagitta

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 17, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jan 17, 2024
Merged
jestabro added a commit that referenced this pull request Jan 17, 2024
@jestabro
Merge pull request #2840 from vyos/mergify/bp/sagitta/pr-2818
31d3d72 
image-tools: T5923: update system_console.py for new GRUB file structure (backport #2818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jestabro @c-po @dmbaturin