Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6489: Add support for CLI config scripts that change the underlaying working configuration #3652

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 15, 2024

Change Summary

We still have some scripts (python owners) for CLI commands that are incompatible with vyos-configd.

T6481 is just another request for such a feature.

Instead of calling my_set and my_delete binary helpers for the store backend we could create a thin Python wrapper who interacts with the unionfs directly - and without the configsession overhead when spawning the cstore code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

image

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jun 15, 2024

👍
No issues in PR Title / Commit Title

@c-po c-po marked this pull request as ready for review June 15, 2024 19:10
@c-po c-po requested a review from a team as a code owner June 15, 2024 19:10
Copy link
Contributor

@jestabro jestabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having discussed this with @c-po , I think it is a smart and useful idea for handling the two existing corner case exceptions to running under vyos-configd --- it should be generalizable when we are ready to drop reliance on CStore.

I would recommend giving it time in current before backporting; I would caution that it should be applied sparingly, and only for config settings that have no effectful behavior in the respective conf-mode script.

@c-po c-po merged commit 14dd6e5 into vyos:current Jun 17, 2024
11 checks passed
@c-po c-po deleted the T6489-unionfs branch June 17, 2024 18:00
@c-po
Copy link
Member Author

c-po commented Jun 24, 2024

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Jun 24, 2024

backport circinus

✅ Backports have been created

c-po added a commit that referenced this pull request Jun 24, 2024
T6489: Add support for CLI config scripts that change the underlaying working configuration (backport #3652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants