-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6489: Add support for CLI config scripts that change the underlaying working configuration #3652
Conversation
…tead of my_set/my_delete
…config filesystem
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having discussed this with @c-po , I think it is a smart and useful idea for handling the two existing corner case exceptions to running under vyos-configd --- it should be generalizable when we are ready to drop reliance on CStore.
I would recommend giving it time in current before backporting; I would caution that it should be applied sparingly, and only for config settings that have no effectful behavior in the respective conf-mode script.
@Mergifyio backport circinus |
✅ Backports have been created
|
Change Summary
We still have some scripts (python owners) for CLI commands that are incompatible with vyos-configd.
T6481 is just another request for such a feature.
Instead of calling my_set and my_delete binary helpers for the store backend we could create a thin Python wrapper who interacts with the unionfs directly - and without the configsession overhead when spawning the cstore code.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: