Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmp: T6489: use new Python wrapper to interact with config filesystem #3694

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 20, 2024

Change Summary

Do no longer use my_set and my_delete as this prevents scripts beeing run under supervision of vyos-configd.

This is a feature which should not be backported to 1.4!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

cpo@LR2.wue3:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_snmp.py
test_snmp_basic (__main__.TestSNMPService.test_snmp_basic) ... ok
test_snmpv3_md5 (__main__.TestSNMPService.test_snmpv3_md5) ... ok
test_snmpv3_sha (__main__.TestSNMPService.test_snmpv3_sha) ... ok
test_snmpv3_view_exclude (__main__.TestSNMPService.test_snmpv3_view_exclude) ... ok

----------------------------------------------------------------------
Ran 4 tests in 23.550s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Do no longer use my_set and my_delete as this prevents scripts beeing run under
supervision of vyos-configd.
Copy link

github-actions bot commented Jun 20, 2024

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit 9428146 into vyos:current Jun 21, 2024
9 checks passed
@c-po c-po deleted the T6489-snmpd branch June 21, 2024 06:52
@c-po
Copy link
Member Author

c-po commented Jun 24, 2024

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Jun 24, 2024

backport circinus

✅ Backports have been created

dmbaturin added a commit that referenced this pull request Jun 25, 2024
snmp: T6489: use new Python wrapper to interact with config filesystem (backport #3694)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants