Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[lang]: introduce mana as an alias for gas #3713

Merged
merged 16 commits into from
Jul 27, 2024
Merged

feat[lang]: introduce mana as an alias for gas #3713

merged 16 commits into from
Jul 27, 2024

Conversation

pcaversaccio
Copy link
Collaborator

@pcaversaccio pcaversaccio commented Dec 28, 2023

What I did

In light of EIP-6789, I introduce mana as an alias for gas. Since mana is so far only an alias, I do deliberately not replace all the gas kwargs nor any other gas keywords in the documentation with mana.

How I did it

I introduce a new transaction property called msg.mana that is semantically the same as msg.gas.

How to verify it

Commit message

per EIP-6789 (https://eips.ethereum.org/EIPS/eip-6789), add `msg.mana`
as an alias for `msg.gas`

Description for the changelog

Introduce mana as an alias for gas.

Cute Animal Picture

image

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (24cfe0b) to head (6ccc25a).

Current head 6ccc25a differs from pull request most recent head 162c444

Please upload reports for the commit 162c444 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
- Coverage   91.26%   88.60%   -2.66%     
==========================================
  Files         109      106       -3     
  Lines       15552    15288     -264     
  Branches     3417     3367      -50     
==========================================
- Hits        14193    13546     -647     
- Misses        929     1230     +301     
- Partials      430      512      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcaversaccio pcaversaccio marked this pull request as draft December 28, 2023 16:42
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio self-assigned this Dec 28, 2023
@pcaversaccio pcaversaccio marked this pull request as ready for review December 28, 2023 17:36
@charles-cooper
Copy link
Member

interesting PR, i need to meditate on this one!

@pcaversaccio pcaversaccio changed the title feat: introduce mana as an alias for gas feat[lang]: introduce mana as an alias for gas Mar 26, 2024
@charles-cooper
Copy link
Member

note that after EOF, there won't be any references to gas within the EVM, so there may not be anything to do here

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one change!

pcaversaccio and others added 2 commits July 27, 2024 12:06
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
@charles-cooper charles-cooper enabled auto-merge (squash) July 27, 2024 10:12
@charles-cooper charles-cooper merged commit 9e51684 into vyperlang:master Jul 27, 2024
156 checks passed
@pcaversaccio pcaversaccio deleted the mana branch July 27, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants