-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[lang]: introduce mana
as an alias for gas
#3713
Conversation
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
- Coverage 91.26% 88.60% -2.66%
==========================================
Files 109 106 -3
Lines 15552 15288 -264
Branches 3417 3367 -50
==========================================
- Hits 14193 13546 -647
- Misses 929 1230 +301
- Partials 430 512 +82 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
interesting PR, i need to meditate on this one! |
mana
as an alias for gas
mana
as an alias for gas
note that after EOF, there won't be any references to gas within the EVM, so there may not be anything to do here |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one change!
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
What I did
In light of EIP-6789, I introduce
mana
as an alias forgas
. Sincemana
is so far only an alias, I do deliberately not replace all thegas
kwargs nor any othergas
keywords in the documentation withmana
.How I did it
I introduce a new transaction property called
msg.mana
that is semantically the same asmsg.gas
.How to verify it
Commit message
Description for the changelog
Introduce
mana
as an alias forgas
.Cute Animal Picture