feat[lang]: introduce mana as an alias for gas
#3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
- Coverage 90.97% 88.60% -2.37%
==========================================
Files 106 106
Lines 15288 15288
Branches 3367 3367
==========================================
- Hits 13908 13546 -362
- Misses 942 1230 +288
- Partials 438 512 +74 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
|
interesting PR, i need to meditate on this one! |
pcaversaccio
changed the title
mana as an alias for gasmana as an alias for gas
|
note that after EOF, there won't be any references to gas within the EVM, so there may not be anything to do here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In light of EIP-6789, I introduce
manaas an alias forgas. Sincemanais so far only an alias, I do deliberately not replace all thegaskwargs nor any othergaskeywords in the documentation withmana.How I did it
I introduce a new transaction property called
msg.manathat is semantically the same asmsg.gas.How to verify it
Commit message
feat: introduce `mana` as an alias for `gas`Description for the changelog
Introduce
manaas an alias forgas.Cute Animal Picture