Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[codegen]: make_setter overlap in the presence of staticcall #4128

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 10, 2024

What I did

How I did it

How to verify it

Commit message

this commit fixes another overlap bug in `make_setter`. this is a
variant of the fixes in ad9c10b0b98e2d and 1c8349e867b2b3, specifically
fixing an oversight in ad9c10b0b98e2d - when there is a `staticcall`
contained inside of `make_setter`, there can still be src/dst overlap,
due to read-only re-entrancy(!). this commit adds `staticcall` to the
list of "risky call" opcodes, and adds a poc test case (contributed by
@trocher).

---------

Co-authored-by: trocher <trooocher@proton.me>

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

charles-cooper and others added 2 commits June 10, 2024 13:57
---------

Co-authored-by: trocher <rocher14@live.fr>
@charles-cooper charles-cooper marked this pull request as ready for review June 10, 2024 17:58
@charles-cooper charles-cooper changed the title fix make_setter overlap in the presence of staticcall fix[codegen]: make_setter overlap in the presence of staticcall Jun 11, 2024
@charles-cooper charles-cooper merged commit 7770967 into vyperlang:master Jun 12, 2024
156 checks passed
@charles-cooper charles-cooper deleted the make-setter-staticcall branch June 12, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants